Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "disable_globbing" option to prevent shell from expanding filenames #154

Merged
merged 5 commits into from Apr 12, 2021

Conversation

stefanzweifel
Copy link
Owner

@stefanzweifel stefanzweifel commented Apr 10, 2021

Refs #153.


This PR adds a new disable_globbing option to the Action. This will prevent the shell from expanding filenames.
You can find more details about globbing in bash here:

Why

As reported in #153, in certain scenarios the Action fails to commit changed files. A test has been added to cover this edge case in e610a51.

My first instinct was to disable globbing globally for all executions. But after reading more about set -o noglob I've decided to hide this feature behind a new option.

My gut tells me, that disabling globbing for all would lead just to more problems. 馃し

Bash Script for local testing

I've used the follwing shell script to test the in #153 reported edge case.

#!/bin/bash

rm -rf issue-153-example;
mkdir issue-153-example;
cd issue-153-example;

git init > /dev/null;

mkdir package;

touch package/module.py;
touch setup.py;

git add .;
git commit -m "Init" > /dev/null;


echo "test" > package/module.py;

# Enable/Disable this line to see the effect.
set -o noglob

git status -s -- *.py;

@stefanzweifel stefanzweifel added the enhancement New feature or request label Apr 12, 2021
@stefanzweifel stefanzweifel merged commit 4c05e3d into master Apr 12, 2021
@stefanzweifel stefanzweifel deleted the fixes/153 branch April 12, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants