Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Content of outgoing mail messages in the database #6

Merged
merged 6 commits into from
Jan 5, 2022

Conversation

stefanzweifel
Copy link
Owner

@stefanzweifel stefanzweifel commented Jan 4, 2022

On Twitter the question came up, why the package doesn't store the content/body of outgoging mails.
I honestly didn't think about that at all, as my primary usecase for the packge is to keep track of meta data.

Implementing this feature is trivial, as the Swif_Message instance exposes a getBody() method.

The feature is hidden behind a new configuration flag (sends.store_content) and has to be enabled by the consumer of the package. I will keep it that way in future releases, as I would like to prevent users from shooting themself in the foot. Storing the body of outgoing mails can blow up the size of a database pretty quickly.

Questions to clarify

  • Should I create an additional migration to add the content-column? Or should this be the concern of the consumer? (Like done in the UPGRADE guide for v0 to v1) → Will make this a new major version. The package is too young to already add multiple migrations to it. Will provide instructions in the upgrade guide

@stefanzweifel stefanzweifel self-assigned this Jan 4, 2022
@stefanzweifel stefanzweifel changed the base branch from main to v2 January 5, 2022 18:47
@stefanzweifel stefanzweifel marked this pull request as ready for review January 5, 2022 18:50
@stefanzweifel stefanzweifel merged commit ce34308 into v2 Jan 5, 2022
@stefanzweifel stefanzweifel deleted the feature/contents branch January 5, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant