Add Observer Classifier #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
============================================
- Coverage 94.74% 94.07% -0.68%
- Complexity 227 233 +6
============================================
Files 41 42 +1
Lines 628 658 +30
============================================
+ Hits 595 619 +24
- Misses 33 39 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the last (?) remaining Classifier to
stats: Observers.The Classifier works very similar to the EventListener Classifier. We resolve the Events-Dispatcher from the Laravel application, get all registered listeners, filter through the events and only keep the
eloquent.*ones and finally check, if the registered class matches with the class which should be classified.Closes #128