Update windows-sys to 0.45.0 #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what's going on with the failed tests. |
r-ml
reviewed
Mar 6, 2023
Co-authored-by: Ricardo Maia Louro <rml@maialouro.pt>
|
I get the remaining test failures on the master branch as well when testing locally 🤷 |
|
now we have windows-sys 0.48 |
|
@steffengy between #90 and #89, what's the plan here going forward? Would be nice to keep things moving. |
|
Any chances it can be upgraded to windows-sys 0.48 anytime soon? |
|
Dont see a reason not to merge an update to 0.48 that passes tests. |
|
Closing in favor of #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/microsoft/windows-rs/releases/tag/0.45.0