-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please make Hugo Fresh work for all versions of Hugo. #22
Comments
@onedrawingperday Can I simply put the generated |
@onedrawingperday I've now added the |
Thanks so much for the swift reply! |
Can we re-open this issue? Extended version of Hugo is needed to use the theme currently. |
@mojoa I’m sorry, but I do not plan on making this theme compatible with non-extended versions of Hugo. That would involve setting up a parallel Sass-to-CSS conversion pipeline that I would really prefer not to create. Others are welcome to add that via pull request if they wish. |
Would it be possible to update the instructions to include mention of this dependency? The current step by step is perfect except the end result is a somewhat cryptic error if the user is not aware they need Hugo Extended. |
Oh sure, that’s no problem. I can do that tomorrow. |
Just wondering if you were still planning on updating.. |
As far as I can tell there’s no need for an update here. The theme will work without the extended version of Hugo as demonstrated on the discussion board. Follow these exact steps: hugo new site my-site && cd my-site
git clone https://github.com/lucperkins/hugo-fresh themes/hugo-fresh
rm config.toml
curl -O https://raw.githubusercontent.com/lucperkins/hugo-fresh/master/exampleSite/config.yaml
hugo server If that doesn't work for you then I really don't know what to tell you. I just tried it out with a non-extended version of Hugo. |
The single person who claims it works without the extended version can not explain why it actually does not work. Others state you need it. I am simply spinning up a VM (fedora 28), downloading the Hugo binary and following the instructions listed for your Theme by copying the lines verbatim. Does it work for you without the extended Hugo? It should take you less than 5 minutes to verify what I am saying.. I may be wrong and would love to know. Regards, |
It works for me without an extended version of Hugo. I’ve tested it with multiple non-extended versions. |
Wow, OK.. I am assuming this started working only after you "put the generated resources directory in the theme" .. I never got a definitive confirmation from anyone that this change made it possible to use standard Hugo. |
Yes, that is correct. An issue was reported and I fixed it so that the theme would work with standard Hugo. Sorry for the lack of confirmation. |
Finally got around to testing this and unfortunately hugo standard does not work. Any ideas? |
@mojoa I guess you're just going to have to use the extended version. This may not be a resolvable issue. |
Thanks, |
@mojoa Please submit a pull request with those changes |
Hello @lucperkins
This came up in the Hugo forum today: https://discourse.gohugo.io/t/hugo-fresh-a-wonderful-theme-for-learning-new-hugo-features/13792/2 from a user who tried to use your theme without having installed Hugo Extended.
Recently a decision was made that Hugo themes assets should be considered as stable and theme authors who use Hugo Extended features should commit their
/resources/
directory so that a theme works in all versions of Hugo. See here for the relevant discussion.Can you please look into it?
Thank you very much!
CC / @digitalcraftsman
The text was updated successfully, but these errors were encountered: