Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for bad certificate #8

Merged
merged 3 commits into from
Jul 3, 2021
Merged

Hotfix for bad certificate #8

merged 3 commits into from
Jul 3, 2021

Conversation

bix0r
Copy link
Member

@bix0r bix0r commented Jul 3, 2021

See information here: https://island.is/rof-innskraning/leidbeiningar-fyrir-taeknifolk
And: pmm1/islandis-login#6

Copy from the mojoweb pull request:

So the CA bundle used to sign the SAML message for island.is authentication requests has been updated, and some of the details of the issuer has changed.
The old certificate will be invalid on july 3rd at 15:00 GMT, so any users of this library will have to update it with this change as well.
This is an immediate issue affecting all users of island.is login using the old login system.
If you wish to test the login before the change is made, you can authenticate against this URL:
This change will fix the certificate authority matching.

bix0r added 2 commits July 3, 2021 12:53
See information here: https://island.is/rof-innskraning/leidbeiningar-fyrir-taeknifolk
And: pmm1/islandis-login#6

Copy from the mojoweb pull request:
> So the CA bundle used to sign the SAML message for island.is authentication requests has been updated, and some of the details of the issuer has changed.
> The old certificate will be invalid on july 3rd at 15:00 GMT, so any users of this library will have to update it with this change as well.
> This is an immediate issue affecting all users of island.is login using the old login system.
> If you wish to test the login before the change is made, you can authenticate against this URL:
> This change will fix the certificate authority matching.
@bix0r bix0r requested a review from sunkan July 3, 2021 10:59
@bix0r bix0r requested a review from stefna-valur July 3, 2021 12:04
Copy link
Contributor

@stefna-valur stefna-valur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working on a live website when using the test method provided by island.is

@sunkan sunkan merged commit b79d569 into master Jul 3, 2021
Copy link

@Stalfur Stalfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants