Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Fix Snowball matrix size mismatch #1264

Merged
merged 1 commit into from Aug 19, 2019
Merged

Conversation

dbmcclain
Copy link
Contributor

  • could happen if participants disagree on commit_phase_participants

@dbmcclain dbmcclain requested a review from vldm August 16, 2019 15:00
Copy link
Contributor

@vldm vldm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbmcclain dbmcclain force-pushed the dm-fix-snowball-matrix-mismatch branch from 28b1bef to d25fe08 Compare August 16, 2019 16:23
- could happen if participants disagree on commit_phase_participants

add sharing of commit_phase_participants with commitment
check during commit receive that we agree in number and in detail about commit_phase_participants

fix errant code
@dbmcclain dbmcclain force-pushed the dm-fix-snowball-matrix-mismatch branch from d25fe08 to 991cd29 Compare August 16, 2019 16:39
@rtsisyk rtsisyk merged commit 4a0fae3 into dev Aug 19, 2019
@rtsisyk rtsisyk deleted the dm-fix-snowball-matrix-mismatch branch August 20, 2019 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants