fix: Broken build process, introduced by dynamically importing packag…

…e.json
steilerDev · Aug 28, 2023 · 8d13be1 · 8d13be1
1 parent 80cfa9b
commit 8d13be1
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 10 deletions.
diff --git a/app/knip.config.jsonc b/app/knip.config.jsonc
@@ -8,11 +8,9 @@
         "eslint-plugin-tsdoc", // Loaded by eslint.config.json
         "ts-json-schema-generator", // Loaded by 'build-schema' script
         "typedoc-plugin-markdown", // Loaded by 'typedoc' script
-        "typedoc-github-wiki-theme", // Loaded by 'typedoc' script
-        "@backtrace-labs/javascript-cli" // Loaded by 'postbuild' script
+        "typedoc-github-wiki-theme" // Loaded by 'typedoc' script
     ],
     "ignoreBinaries": [ // Not sure why they are reported as unused
-        "backtrace-js", // Loaded by 'postbuild' script
         "eslint.config.json",
         "package.json"
     ]

diff --git a/app/package.json b/app/package.json
@@ -15,12 +15,15 @@
     "clean": "rm -rf bin/ coverage/ doc/ node_modules/ package-lock.json src/lib/resource-manager/schemas/",
     "prebuild:lint": "npx eslint -c eslint.config.json --fix --ext .ts ./src ./test",
     "prebuild:knip": "npx knip --no-exit-code --config knip.config.jsonc",
-    "prebuild": "npm run prebuild:lint && npm run prebuild:knip",
+    "prebuild:clean": "rm -rf bin/",
+    "prebuild": "npm run prebuild:lint && npm run prebuild:knip && npm run prebuild:clean",
     "build:schema": "./build/schema.sh",
     "build:typescript": "npx tsc",
     "build:typedoc": "npx typedoc --plugin typedoc-plugin-markdown --plugin typedoc-github-wiki-theme",
     "build": "npm run build:schema && npm run build:typescript",
-    "postbuild": "npx backtrace-js process bin/",
+    "postbuild:clean": "mv bin/src/* bin/ && rm -rf bin/src bin/package.json",
+    "postbuild:sourcemap": "npx backtrace-js process bin/",
+    "postbuild": "npm run postbuild:clean && npm run postbuild:sourcemap",
     "test": "NODE_NO_WARNINGS=1 NODE_OPTIONS='--experimental-vm-modules' npx jest --config jest.config.json test/unit/",
     "test:all": "NODE_NO_WARNINGS=1 NODE_OPTIONS='--experimental-vm-modules' npx jest --config jest.config.json",
     "test:api": "NODE_NO_WARNINGS=1 NODE_OPTIONS='--experimental-vm-modules' npx jest --config jest.config.json test/api/",

diff --git a/app/src/lib/resources/main.ts b/app/src/lib/resources/main.ts
@@ -24,7 +24,7 @@ export namespace Resources {
         name: PackageData.name,
         version: PackageData.version,
         description: PackageData.description,
-    }
+    };
 
     /**
      * Prepares the global singleton instances. This includes the ResourceManager, NetworkManager, Validator and EventManager.

diff --git a/app/src/lib/resources/resource-manager.ts b/app/src/lib/resources/resource-manager.ts
@@ -74,8 +74,6 @@ export class ResourceManager {
         }
     }
 
-
-
     /**
      * @returns The data dir read from the CLI Options
      */

diff --git a/app/test/unit/resources.resource-manager.test.ts b/app/test/unit/resources.resource-manager.test.ts
@@ -285,8 +285,6 @@ describe(`ResourceManager`, () => {
             resourceManager = prepareResources(true, resources as any)!.manager;
         });
 
-
-
         describe(`dataDir`, () => {
             test(`should return the data dir from the resources`, () => {
                 expect(resourceManager.dataDir).toEqual(resources.dataDir);