Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: Removing unnecessary files from npm distribution tarball
- Loading branch information
1 parent
9d4616c
commit a0fb08f
a0fb08fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steilerDev There is also the alternative of
files[]: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#files in package.json which is an allow-list rather than a deny-list.a0fb08fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that be preferable? 🤔
I'd put in
files: [ 'bin/**/*' ], right?a0fb08fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that is cleaner - now part of
1.2.0-beta.3- thanks for the feedback!a0fb08fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just a suggestion, @steilerDev! In my experience it is very easy to accidentally add new folders/files that are not needed for the package. For example generated temp files or some other files that might even be git ignored.
in the best case it might just be package bloat, in the worst case you might leak passwords or tokens.
a0fb08fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the appeal - this is my first "real" node project - always looking for best practices :)