Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on missing cstdint types. #267

Merged
merged 1 commit into from Oct 8, 2022
Merged

Fix build error on missing cstdint types. #267

merged 1 commit into from Oct 8, 2022

Conversation

carlo-bramini
Copy link
Contributor

While building VST3SDK, I got this error on VSTGUI:

[ 60%] Building CXX object VSTGUI.build/standalone/CMakeFiles/vstgui_standalone.dir/source/uidescriptionwindowcontroller.cpp.o
In file included from /home/carlo/packages/vst3sdk/vst3sdk/vstgui4/vstgui/standalone/source/uidescriptionwindowcontroller.cpp:5:
/home/carlo/packages/vst3sdk/vst3sdk/vstgui4/vstgui/standalone/source/../../lib/algorithm.h:15:63: error: ‘int32_t’ does not name a type
   15 | template <typename Iter, typename Type, typename ResultType = int32_t>
      |                                                               ^~~~~~~
/home/carlo/packages/vst3sdk/vst3sdk/vstgui4/vstgui/standalone/source/../../lib/algorithm.h:9:1: note: ‘int32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
    8 | #include <algorithm>
  +++ |+#include <cstdint>
    9 |

The easy correction suggested by GCC fixed the error.
I think that this fix is also a good programming pratice, by not assuming that something is included by someone else, so I hope that it could be accepted.

While building VST3SDK, I got this error on VSTGUI:

[ 60%] Building CXX object VSTGUI.build/standalone/CMakeFiles/vstgui_standalone.dir/source/uidescriptionwindowcontroller.cpp.o
In file included from /home/carlo/packages/vst3sdk/vst3sdk/vstgui4/vstgui/standalone/source/uidescriptionwindowcontroller.cpp:5:
/home/carlo/packages/vst3sdk/vst3sdk/vstgui4/vstgui/standalone/source/../../lib/algorithm.h:15:63: error: ‘int32_t’ does not name a type
   15 | template <typename Iter, typename Type, typename ResultType = int32_t>
      |                                                               ^~~~~~~
/home/carlo/packages/vst3sdk/vst3sdk/vstgui4/vstgui/standalone/source/../../lib/algorithm.h:9:1: note: ‘int32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
    8 | #include <algorithm>
  +++ |+#include <cstdint>
    9 |

The easy correction suggested by GCC fixed the error.
I think that this fix is also a good programming pratice, by not assuming that something is included by someone else, so I hope that it could be accepted.
@scheffle scheffle merged commit 1f0d108 into steinbergmedia:develop Oct 8, 2022
@carlo-bramini carlo-bramini deleted the fix-cstdint-1 branch October 9, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants