Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .cif/.pdb in filenames & remove _MODEL_ # in .lookup #261

Merged
merged 3 commits into from
May 7, 2024

Conversation

ChaSooyoung
Copy link
Contributor

No description provided.

@@ -74,6 +74,17 @@ static inline bool compareByFirst(const std::pair<T, U>& a, const std::pair<T, U
return a.first < b.first;
}

std::string removeMODEL(const std::string& input) {
size_t modelIndex = input.find("MODEL");
if (modelIndex == std::string::npos)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't omit curly brackets {} for single line if statements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! thanks

@@ -74,6 +74,17 @@ static inline bool compareByFirst(const std::pair<T, U>& a, const std::pair<T, U
return a.first < b.first;
}

std::string removeMODEL(const std::string& input) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use camelCaseing.

@@ -853,8 +864,9 @@ int structcreatedb(int argc, const char **argv, const Command& command) {
for (unsigned int id = 0; id < readerHeader.getSize(); id++) {
char *header = readerHeader.getData(id, 0);
entry.id = readerHeader.getDbKey(id);
entry.entryName = Util::parseFastaHeader(header);
std::pair<size_t, unsigned int> fileIdModelEntry = entrynameToFileId[entry.entryName];
std::string entryNamewithMODEL = Util::parseFastaHeader(header);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please camelCase this too entryNameWithModel

@milot-mirdita milot-mirdita merged commit d326ca0 into steineggerlab:master May 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants