Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SummonerAPI#getSummonerByName not working in 2 letters korean #24

Closed
namjug-kim opened this issue May 21, 2021 · 1 comment
Closed

SummonerAPI#getSummonerByName not working in 2 letters korean #24

namjug-kim opened this issue May 21, 2021 · 1 comment

Comments

@namjug-kim
Copy link

In the case of the Korean summoner's name, 3 letters, including a space, are possible.

The value of SUMMONER_NAME_PLACEHOLDER is set through A, excluding white spaces.

other case RIOT summoner v4 api works, bu in case of 2 letter korean, it doesn't work.

  1. search 삼재 excluding white spaces
1. request
curl --location --request GET 'https://kr.api.riotgames.com/lol/summoner/v4/summoners/by-name/삼재' \
--header 'X-Riot-Token: ${RIOT_TOKEN}'

=================

2. response
{
    "status": {
        "message": "Data not found - summoner not found",
        "status_code": 404
    }
}
  1. search 삼 재 including white spaces
1. request
curl --location --request GET 'https://kr.api.riotgames.com/lol/summoner/v4/summoners/by-name/삼 재' \
--header 'X-Riot-Token: ${RIOT_TOKEN}'

=================

2. response
{
    "id": "AQFycDGccB-7F4yNqBJQm2SxUPN-BZEScORQxzaki6PYNfw",
    "accountId": "KZq42AL80n6BD_HnzXUnRjgHm6zF-NfZeMY9eQT8oKwbn1DadlbSdyUW",
    "puuid": "SK8_OVHyTfOW__-eKgdIjboBj_5BkSOwYh0iPYRsKfamHwSZ_c5H-T5OB6LKGmnncAkKn8bBJtZlwQ",
    "name": "삼 재 ",
    "profileIconId": 4629,
    "revisionDate": 1621368768000,
    "summonerLevel": 169
}
@stelar7
Copy link
Owner

stelar7 commented Apr 29, 2022

Fixed in 2.1.7

@stelar7 stelar7 closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants