Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build scripts and vcpkg #18

Closed
Cambloid opened this issue Jan 31, 2021 · 5 comments · Fixed by #24
Closed

Build scripts and vcpkg #18

Cambloid opened this issue Jan 31, 2021 · 5 comments · Fixed by #24
Labels
enhancement New feature or request

Comments

@Cambloid
Copy link
Contributor

The original author created some powershell scripts to build openvslam on windows

https://github.com/shinsumicco/openvslam-on-msvc

I tried with vcpkg but it fails when setting the -DDBoW2_DIR in the command line.
It works when DBoW2_DIR path is set in the cmake script.

Is this caused by vcpkg?

@ymd-stella
Copy link
Contributor

I tried with vcpkg but it fails when setting the -DDBoW2_DIR in the command line.
It works when DBoW2_DIR path is set in the cmake script.

I would like to see details of the procedure that fails and the procedure that succeeds.
I may be able to give you some advice, or someone else may be able to.

Is this caused by vcpkg?

I don't know, I've never tried to build on Windows.
I'm not even sure how useful it would be to use vcpkg.

Contributions are welcome.
But we can't safely merge them until the Windows version of CI is ready.
I'm considering using CircleCI.

@Cambloid
Copy link
Contributor Author

Cambloid commented Feb 3, 2021

vcpkg makes it much easier especially when you have a cmake project and many dependencies
the issue with DBoW2_DIR got resolved with cmake presets

I just made a pull request wih a possible solution:
#23

@ymd-stella ymd-stella reopened this Feb 3, 2021
@ymd-stella ymd-stella linked a pull request Feb 3, 2021 that will close this issue
@ymd-stella
Copy link
Contributor

@Cambloid It seems that the change find_package(SuiteSparse CONFIG) is causing the error cs.h: No such file or directory .

@ymd-stella
Copy link
Contributor

I reverted the changes in CMakeLists.txt.
Please let me know if you have a successful build using vcpkg without affecting existing builds.

@Cambloid
Copy link
Contributor Author

Cambloid commented Feb 4, 2021

the build fails with the missing include file on windows.

would something like this be acceptable?:
if(MSVC)
find_package(SuiteSparse CONFIG)
else()
find_package(SuiteSparse)
endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants