This repository has been archived by the owner on Nov 30, 2020. It is now read-only.
Safe tx resubmit #47
Merged
Safe tx resubmit #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullstyle
approved these changes
Dec 14, 2017
|
No problem Scott! Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a safe tx resubmit function that can be executed when Account Viewer is not sure if tx has been submitted successfully or not (ex. connection timeouts).
It will display the following message in such cases:
Please note that we display: "Send another transaction" link if we get a response body from horizon. We hide this link in this view to disallow users to create another transaction.
Because of the fact that a lot of code has been moved I recommend reviewing this PR in the split view mode.