This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Add "target price" and "target amount" to modify offer log line in sellSideStrategy #3
Labels
Comments
nikhilsaraf
added
good first issue
nikhilsaraf
pushed a commit
that referenced
this issue
Oct 29, 2018
* cap3: 1 - implement liabilities for XLM * cap3: 2 - integrate liabilities into willOversell and willOverbuy methods * cap3: 3 - remove fractionalReserveMultiplier cli arg * cap3: 4 - offers in the same tx will contribute to liabilities, incorporate into cachedLiabilities * cap3: 5 - handle case of setting incrementalBuy for native asset * cap3: 6 - refactored willOversell and willOverbuy to extract common offer logic * cap3: 7 - added support for checking XLM fee and min reserves * cap3: 8 - update ordering of operations in strategies (sellSideStrategy, mirrorStrategy) when not all offers can be placed — always place inside orders first * cap3: 9 - native fee inclusion checks source/trader account usage * cap3: 10 - delete offer if nothing was created and we were planning to modify an existing offer * cap3: 11 - prepend deleteOps so we "free" up our liabilities capacity to place the new/modified offers * cap3: 12 - better error propagation from sdex.createModifySellOffer * cap3: 13 - extracted liability updates after placing/modifying offers to callers in sellSideStrategy and mirrorStrategy * cap3: 14 - prepend deleteOps for mirror strategy too * cap3: 15 - log liabilities in trader.go after resetting and after updating ops * cap3: 16 - add liabilities in mirror strat * cap3: 17 - added support for partial offers in sellSideStrategy, refactored updateSellLevel * cap3: 18 - updated comment when resetting cached liabilities * cap3: 19 - add current offer amounts to liabilities when not modifying an offer * cap3: 20 - add a caching layer for asset balances to reduce requests * cap3: 21 - cleaner logging of asset balance and trust amounts * cap3: 22 - let new capacity constraint system handle max limits for sellSideStrategy * cap3: 23 - reset caches before pruning and updating operations * cap3: 24 - update CHANGELOG * new release: v1.0.0-rc2 * expand assets allowed to use with the Kraken exchange, fixes #13 * new release: v1.0.0-rc3 * remove default rate offset percent from sample strategy config files * Print strat (#15) * Update trade.go * Update trade.go * Update trade.go * enable Travis CI, closes #17 (#18) * enable Travis CI * go_import_path * travis: ./bin/kelp version * doc clarify full path needed for configs (#16)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Desired Behavior
I want to be able to see the target price and target amount when modifying an existing sell offer
Impact
The desired behavior will allow me to see what the new price and amount will be for a given update cycle.
Feature Suggestion
// A succinct description of how you want to achieve the desired behavior.
// If you have looked at the code and know exactly what code changes are needed then please consider submitting a pull request instead.
// If this feature does not exist anywhere else then please restrict any details to the Specification section below.
We can achieve the desired behavior by updating this log line in sellSideStrategy.go.
The text was updated successfully, but these errors were encountered: