Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

app crashes are not recorded in the log file when using the --log option #48

Closed
nikhilsaraf opened this issue Nov 9, 2018 · 0 comments
Assignees
Milestone

Comments

@nikhilsaraf
Copy link
Contributor

Describe the bug

If the bot was to crash with a panic then it is not logged to the file when using the --log option

Expected behavior

I think the correct behavior in this situation is for the bot to log these errors to the file as well so we can fully depend on the log files

Frequency

The frequency is: Always

Steps To Reproduce

Here are the steps to reproduce the issue (see attachments in section below):

  1. Create a strategy with a panic operation to force it to crash
  2. Start the bot using the --log flag
  3. the bot will crash and the standard out will display the panic but the log file will not.

Possible Solution

This bug can be fixed by catching any panics at the highest level and logging that before exiting.

Your Environment

git hash: 8e6fae2

@nikhilsaraf nikhilsaraf self-assigned this Nov 9, 2018
@nikhilsaraf nikhilsaraf added this to the v1.2.0 milestone Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant