Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support String or Number Unmarshalling in Int64 fields #1912

Closed
7 tasks done
abuiles opened this issue Nov 12, 2019 · 4 comments
Closed
7 tasks done

Support String or Number Unmarshalling in Int64 fields #1912

abuiles opened this issue Nov 12, 2019 · 4 comments
Assignees
@abuiles
Milestone
Horizon 0.24.0

Comments

@abuiles
Copy link
Contributor

abuiles commented Nov 12, 2019 •
edited
Loading

Add UnmarshalJSON to the following structs, allowing string or number where an Int64 is expected

  • go/protocols/horizon/effects/main.go:260:20: NewSeq int64 json:"new_seq"
  • go/protocols/horizon/operations/main.go:139:10: OfferID int64 json:"offer_id"
  • go/protocols/horizon/operations/main.go:146:10: OfferID int64 json:"offer_id"
  • go/protocols/horizon/effects/main.go:260:20: OfferID int64 json:"offer_id"
  • go/protocols/horizon/main.go:228:21: ID int64 json:"id"
  • go/protocols/horizon/main.go:376:16: Timestamp int64 json:"timestamp"
  • go/protocols/horizon/main.go:377:16: TradeCount int64 json:"trade_count"
@abuiles abuiles added this to the Horizon 0.24.0 milestone Nov 12, 2019
@abuiles abuiles self-assigned this Nov 12, 2019
@ire-and-curses
Copy link
Member

This is for the SDK right?

@abuiles
Copy link
Contributor Author

abuiles commented Nov 12, 2019

@ire-and-curses no, this is a tracker for #1909 (review)

@abuiles
Copy link
Contributor Author

abuiles commented Nov 12, 2019

@ire-and-curses here's the PR for the js-sdk stellar/js-stellar-sdk#457

This was referenced Nov 13, 2019
Closed
Merged
@abuiles abuiles closed this as completed Nov 18, 2019
@abuiles
Copy link
Contributor Author

abuiles commented Nov 18, 2019

This was finished.

This was referenced Jan 20, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
@fracek fracek mentioned this issue Jan 24, 2020
Closed
4 tasks
@bartekn bartekn mentioned this issue Feb 10, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuiles abuiles

Labels
None yet
Projects
None yet
Milestone
Horizon 0.24.0
Development

No branches or pull requests
2 participants
@abuiles @ire-and-curses