How to build RevokeSponsorshipOp on txbuild?

[abuiles]

RevokeSponsorshipOp requires users to build a LedgerKey or a struct for signers sponsorships. We need to expose a helper or helpers to make it easy for users to create such operation.

A possible approach could be to add functions for each ledger key. For example:

func RevokeTrustLineSponsorshipOp(account string, asset txnbuild.Asset)
func RevokeAccountSponsorshipOp(account string)
func RevokeSignerSponsorshipOp(account string, signer string) // optionally it could receive a txnbuild.Account instead of a string
...

[2opremio]

That's one good option.

Alternatively we could reuse the xdr.RevokeSponsorshipOp or, if we want to hide the ledger key, we could create a union type similar to to xdr.LedgerKey, extended with a signer option. Something like:

func RevokeTrustLineSponsorshipOp(SponsorshipRevocationTarget)

type SponsorshipRevocationTargetType  int

const (
	SponsorshipRevocationTargetTypeAccount          SponsorshipRevocationTargetType = iota
	SponsorshipRevocationTargetTypeTrustline        SponsorshipRevocationTargetType
	SponsorshipRevocationTargetTypeOffer            SponsorshipRevocationTargetType
	SponsorshipRevocationTargetTypeData             SponsorshipRevocationTargetType
	SponsorshipRevocationTargetTypeBalance          SponsorshipRevocationTargetType
	SponsorshipRevocationTargetTypeSigner           SponsorshipRevocationTargetType
)

type SponsorshipRevocationTarget struct {
	Type             SponsorshipRevocationTargetType
	Account          *string
	TrustLine        *SponsorshipRevocationTargetTrustLine
	Offer            *SponsorshipRevocationTargetOffer
	Data             *SponsorshipRevocationTargetData
	ClaimableBalance *SponsorshipRevocationTargetClaimableBalance
	Signer           *SponsorshipRevocationTargetSigner
}

type SponsorshipRevocationTargetTrustLine  {
	AccountId string
	Asset     Asset
}

[...]

[2opremio]

@abuiles are you taking up this one? (i.e. implementing the RevokeSponsorship in txnbuild). I need it for integration tests.

[abuiles]

@2opremio no. I thought you were doing it as part of the integration test work. Let's do the implementation first in the internal txnbuild and we can work on the official one next week.

[2opremio]

Sure