Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: txnbuild: add ability to create TransactionParams from Transaction #3649

Open
leighmcculloch opened this issue Jun 1, 2021 · 1 comment
Labels
feature request txnbuild 2nd-generation transaction build library for Go SDK

Comments

@leighmcculloch
Copy link
Member

What

Add ability to create TransactionParams from Transaction.

Why

So that we can load a Transaction, edit it, then resign it, etc.

As far as I can tell the txnbuild package does not contain functionality for this.

Since the way to provide parameters to a new Transaction is to use the TransactionParams type, it seems fitting that to modify a Transaction, which is largely immutable other than for signing, the method to do so would be to construct a TransactionParams from a Transaction.

There are plenty of use cases where different parties will sign a transaction, but then decide they need to modify it and resign it. SEP-8 is one example. Payment channels has a flow that will require it as well where a prior signed transaction stored as XDR will need reparsing, modifying, and resigning.

@leighmcculloch leighmcculloch added txnbuild 2nd-generation transaction build library for Go SDK feature request labels Jun 1, 2021
@MishraShivendra
Copy link
Contributor

Hi @leighmcculloch Hope this feature is still relevant.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Development

No branches or pull requests

2 participants