Remove --captive-core-reuse-storage-dir flag

[bartekn]

In #3715 we added a feature flag --captive-core-reuse-storage-dir (false by default) to allow disabling permament buckets directory of Captive Stellar-Core. This was done because stellar/stellar-core#3085 could leave buckets dir corrupted. Now that bug is fixed in 17.3.0 we can schedule removing the feature flag when Protocol 18 is live (this will require everyone to upgrade to Stellar-Core 18.0.0 that contains a fix).

[MonsieurNicolas]

If this is fixed in core 17.3.0 why do you need to wait for protocol 18 to go live? Older core releases are not supported per our security release model (30 days after a release we publish details of any potential security issue) . So it's fine to require newer core versions. As 17.4.0 is out, you can require 17.4.0 in your next Horizon release no problem.

[bartekn]

I was just running CC locally and this output reminded me about your comment:

INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: Blockdaemon_Validator_1, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: Blockdaemon_Validator_2, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: Blockdaemon_Validator_3, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: coinqvest_finland, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: coinqvest_germany, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: coinqvest_hong_kong, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: keybase_1, server: stellar-core 17.0.0 (096f6a766ed6aa08e13519371e842b90f01df841), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: keybase_2, server: stellar-core 17.0.0 (096f6a766ed6aa08e13519371e842b90f01df841), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: keybase_io, server: stellar-core 17.0.0 (096f6a766ed6aa08e13519371e842b90f01df841), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: lobstr_1_europe, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: lobstr_2_europe, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: lobstr_3_north_america, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: lobstr_4_asia, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: lobstr_5_australia, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: satoshipay_frankfurt, server: stellar-core 17.1.0 (16710ebfd9f64656fdad5e40b64f05b7b486c9d2), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: satoshipay_iowa, server: stellar-core 17.1.0 (f31c8f90d7abc634fc89818e013a32dc5f2badc8), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: satoshipay_singapore, server: stellar-core 17.1.0 (16710ebfd9f64656fdad5e40b64f05b7b486c9d2), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: sdf_1, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: sdf_2, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: sdf_3, server: stellar-core 17.4.0 (c5f6349b240818f716617ca6e0f08d295a6fad9a), currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: wirexSG, server: v17.4.0, currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: wirexUK, server: v17.4.0, currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.026+02:00] History: Archive information: [name: wirexUS, server: v17.4.0, currentLedger: 37447039]  pid=83287 service=ingest subservice=stellar-core
INFO[2021-09-21T14:38:20.403+02:00] History: Catching up to ledger 37447038: downloading and verifying buckets: 19/21 (90%)  pid=83287 service=ingest subservice=stellar-core

As you can see there are still many Tier 1 validators running 17.0.0 and 17.1.0 and this GH issue requires 17.3.0 or later.

[bartekn]

Network is now at Protocol 18: moving this to Current Sprint.