Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LedgerRecord is missing successful_transaction_count and failed_transaction_count #731

Closed
acharb opened this issue Dec 21, 2021 · 0 comments · Fixed by #740
Closed

LedgerRecord is missing successful_transaction_count and failed_transaction_count #731

acharb opened this issue Dec 21, 2021 · 0 comments · Fixed by #740
Labels

Comments

@acharb
Copy link

acharb commented Dec 21, 2021

Describe the bug
The LedgerRecord interface is missing the two fields:
successful_transaction_count
failed_transaction_count

these two fields are listed in our docs but missing from the js-sdk. They are however in the go-sdk.

What version are you on?
9.1.0

Additional context
Was looking for a type to handle the below code, when I realized the fields are missing

var horizon = new stellarSdk.Server("https://horizon.stellar.org");
        horizon
          .ledgers()
          .cursor(pagingToken)
          .limit(200)
          .stream({
            onmessage: (ledger: ServerApi.LedgerRecord) => {
              ledger.successful_transaction_count // error TS2339: Property 'successful_transaction_count' does not exist on type 'LedgerRecord'.
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant