Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate bundle size growth after modernization #824

Closed
Shaptic opened this issue May 15, 2023 · 1 comment
Closed

Investigate bundle size growth after modernization #824

Shaptic opened this issue May 15, 2023 · 1 comment
Assignees

Comments

@Shaptic
Copy link
Contributor

Shaptic commented May 15, 2023

Parent Epic: #792


Description

After the work that went into releasing v11.0.0-beta, the bundle size has actually increased overall despite stellar-base getting much (67%) smaller. Some investigation needs to be done to uncover why this is the case, then the (heretofore unknown) work needs to be done to resolve this.

Some progress has already been made by removing and/or minimizing unnecessary dependencies (see #822 and #823), but more needs to be done. Hypotheses include:

  • unavoidable dependencies growing in size since the upgrade (e.g. I think axios got a buttload bigger)
  • glaring bundler mistakes (e.g. some dependencies not being minimized?)
  • unnecessarily aggressive global imports (e.g. you need some lib.module.tinyFunction but you import * from lib, instead)
  • other dependencies that provide redundant native functionality

Current Statistics

A reduction in the current bundle size:

Assets:
  stellar-sdk (2.02 MiB)
  stellar-sdk.min (725 KiB)

to be closer to (or, ideally, better than) that of the latest stable version (v10.4.1):

Assets: 
  stellar-sdk.js (1.65 MiB)
  stellar-sdk.min.js (568 KiB)

Acceptance Criteria

A clear path forward on how to reduce bundle size.

@Shaptic Shaptic self-assigned this May 22, 2023
@Shaptic Shaptic changed the title Investigate and resolve bundle size growth after modernization Investigate bundle size growth after modernization May 24, 2023
@Shaptic
Copy link
Contributor Author

Shaptic commented May 24, 2023

#836 tracks work that came out of investigating this issue.

@Shaptic Shaptic closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants