Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Soroban LedgerEntry size #716

Closed
MonsieurNicolas opened this issue Mar 3, 2023 · 1 comment
Closed

Limit Soroban LedgerEntry size #716

MonsieurNicolas opened this issue Mar 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@MonsieurNicolas
Copy link
Contributor

Similar to what we do as a "catch all" to limit transaction size (done outside of env - stellar/stellar-core#3672 ): we need a limit (network setting) on how big any Soroban ledger entry can get:
while limits on SCVals , keys (#629) , etc should be enough, there is a possibility that we miss something (or a combination of things) and that can become a problem for the network over time.

It seems we should be able to enforce this within env, but if not, we should enforce this in the core bridge (when we convert entries into binary blobs when crossing back to C++).

@jayz22
Copy link
Contributor

jayz22 commented May 4, 2023

Resolved by stellar/stellar-core#3731.

@jayz22 jayz22 closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants