Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Cargo.toml files for tests #428

Closed
jonjove opened this issue Aug 11, 2022 · 4 comments
Closed

Clean up Cargo.toml files for tests #428

jonjove opened this issue Aug 11, 2022 · 4 comments
Assignees

Comments

@jonjove
Copy link
Contributor

jonjove commented Aug 11, 2022

What problem does your feature solve?

There are many inconsistencies and unnecessary lines in the Cargo.toml files for tests, such as #426 (comment).

What would you like to see?

Make them uniform and bring them in line with our current development guidelines.

What alternatives are there?

N/A

@leighmcculloch
Copy link
Member

leighmcculloch commented Aug 11, 2022

I recently went through the SDK repos Cargo.toml files and did this. Can you point me to the inconsistencies you see? The only one that stands out is the one mentioned in #426 (comment), but that's actually fine.

@jonjove
Copy link
Contributor Author

jonjove commented Aug 11, 2022

Some of them depend on proptest (eg. add_i32) and some don't (eg. add_i64), but as far as I can tell none of them are actually using it. contract_data, linear_memory, vec don't specify publish = false but other tests do.

@leighmcculloch
Copy link
Member

Thanks, adding this to the August iteration because the publish = false are likely to cause issues with releasing at the end of the iteration.

@leighmcculloch leighmcculloch self-assigned this Sep 14, 2022
@leighmcculloch
Copy link
Member

I removed prop_test recently from the sdk repo, and the publish thing got fixed I think at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants