Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZkVM: Spec Questions #71

Closed
kevaundray opened this issue Feb 11, 2019 · 4 comments
Closed

ZkVM: Spec Questions #71

kevaundray opened this issue Feb 11, 2019 · 4 comments

Comments

@kevaundray
Copy link
Contributor

kevaundray commented Feb 11, 2019

https://github.com/interstellar/slingshot/blob/main/zkvm/spec/ZkVM.md#aggregated-signature

"Commit all verification keys P[i] in order, one by one"

Would this be in lexographical order?

Can the terms clear-text scalars and non-secret scalars be used interchangeably?

The term "Flavour" was defined in the Cloak protocol, should we copy over the definition for the specs?

@oleganza
Copy link
Contributor

"Commit all verification keys P[i] in order, one by one"

In the order they are provided. Since they come from signtx instructions, the order corresponds to the order of use of these instructions.

@oleganza
Copy link
Contributor

Can the terms clear-text scalars and non-secret scalars be used interchangeably?

Yup. Probably need to fix up the spec to use "clear-text" across the board for clarity and to avoid this ambiguity.

@oleganza
Copy link
Contributor

The term "Flavour" was defined in the Cloak protocol, should we copy over the definition for the specs?

We can probably simply link to the Cloak spec from the terms quantity and flavor in the Value definition.

@oleganza
Copy link
Contributor

I'll leave this issue open until i tweak the spec to address these points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants