Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDR format is not standardized (Version: The latest source code) #2954

Closed
overcat opened this issue Mar 10, 2021 · 2 comments · Fixed by #2955
Closed

XDR format is not standardized (Version: The latest source code) #2954

overcat opened this issue Mar 10, 2021 · 2 comments · Fixed by #2955
Labels
Projects

Comments

@overcat
Copy link
Contributor

overcat commented Mar 10, 2021

Issue Description

According to the contents of RFC-4506, the format of the enum-body should be

enum-body:
         "{"
            ( identifier "=" value )
            ( "," identifier "=" value )*
         "}"

However, the XDR definition in the source code does not meet the above requirements, which may cause some XDR parsers to fail to parse this code normally.

Expected Result

Follow the RFC-4506 specification.

@jonjove
Copy link
Contributor

jonjove commented Mar 10, 2021

Thank you for pointing this out. I opened xdrpp/xdrpp#26 to track making the XDR compiler more compliant. This issue will be resolved by #2918, because it adds an additional value to that enum.

@overcat
Copy link
Contributor Author

overcat commented Mar 10, 2021

@jonjove Thank you, I have closed #2955.

@MonsieurNicolas MonsieurNicolas added this to In progress in v15.4.0 Mar 12, 2021
v15.4.0 automation moved this from In progress to Done Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants