Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech debt: cleanup or remove transactions "stacks" #3846

Open
marta-lokhova opened this issue Jul 20, 2023 · 2 comments · Fixed by #4196
Open

tech debt: cleanup or remove transactions "stacks" #3846

marta-lokhova opened this issue Jul 20, 2023 · 2 comments · Fixed by #4196
Assignees
Labels
cleanup refactoring or other internal improvements enhancement

Comments

@marta-lokhova
Copy link
Contributor

To be done after #3782 is completed and rolled out on the network.

The change above makes the notion of "tx stacks" (aka chains of transactions for the same source account) obsolete.
At a minimum, we can change the API so callers like the transaction queue and transaction limiter don't need to be aware of the tx stacks used underneath. We could also potentially simplify the underlying surge pricing ordering mechanism to remove the notion of tx stacks completely, but this might be harder due to the need to validate pre-protocol-20 transaction sets, which still contain tx stacks. This requires investigation to determine code to clean up/remove.

@marta-lokhova marta-lokhova added enhancement cleanup refactoring or other internal improvements labels Jul 20, 2023
@marta-lokhova
Copy link
Contributor Author

As part of this cleanup, we should also remove any logic inside the TransactionQueue module that deals with chains of transactions per source account.

@MonsieurNicolas
Copy link
Contributor

+1 on doing this work. When we do it, we should also revisit tests as all this complexity is not needed and in some cases the intent of the test may not be valid anymore.

I don't think we need to validate pre-20 txsets: when replaying transactions from history, the only thing we need to ensure is that hashes are correct (we don't call checkValid on tx sets and only apply transactions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup refactoring or other internal improvements enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants