Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx queue: pending txs by age counter is buggy #4229

Closed
marta-lokhova opened this issue Mar 4, 2024 · 0 comments · Fixed by #4237
Closed

tx queue: pending txs by age counter is buggy #4229

marta-lokhova opened this issue Mar 4, 2024 · 0 comments · Fixed by #4237
Assignees
Labels

Comments

@marta-lokhova
Copy link
Contributor

Looks like we (I) forgot to update herder.pending-txs.ageX metric and make it separate for classic vs soroban queues. As a result, currently reported values are incorrect, since both queues update/override the same metric (which may cause us to see negative values).

Note that there are a couple of other metrics shared in both queues: banned txs, arb txs, and tx confirmation delay. Those strictly increment counters or add new samples, so we report correct values. We should still split those anyway to make it less error-prone, and easier to reason about different types of traffic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@marta-lokhova and others