Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperbolic tests fail on Windows: ValueError: high is out of bounds for int32 #1700

Closed
huonw opened this issue Jun 22, 2020 · 0 comments
Closed
Assignees
Labels
bug Something isn't working sg-library

Comments

@huonw
Copy link
Member

huonw commented Jun 22, 2020

Describe the bug

CI run on Windows: #1696 https://github.com/stellargraph/stellargraph/pull/1696/checks?check_run_id=793669259
Results: https://gistpreview.github.io/?f35d36d87f30d84d9c39a7e90512b240#3a757c57-c84c-4ba4-9262-33306656c50d

To Reproduce

Run tests on windows

Observed behavior

The following tests fail:

tests.utils.test_hyperbolic.test_poincare_ball_exp_specialisation
tests.utils.test_hyperbolic.test_poincare_ball_distance_self
tests.utils.test_hyperbolic.test_poincare_ball_distance_exp
tests.utils.test_hyperbolic.test_poincare_ball_distance_vs_euclidean

with an error like:

@pytest.fixture
    def seeded():
>       seed = np.random.randint(2 ** 32)

tests\utils\test_hyperbolic.py:25: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
mtrand.pyx:743: in numpy.random.mtrand.RandomState.randint
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

>   ???
E   ValueError: high is out of bounds for int32

_bounded_integers.pyx:1343: ValueError

Expected behavior

Testes should pass.

Environment

Operating system: Windows

Python: 3.6

StellarGraph develop: e9a6ea1

Additional context

N/A

@huonw huonw added bug Something isn't working sg-library labels Jun 22, 2020
@huonw huonw self-assigned this Jun 22, 2020
huonw added a commit that referenced this issue Jun 22, 2020
We can augment our Python-version testing matrix to also run our unit tests on
both Linux and Windows. This will make it more likely that StellarGraph works
without issue on Windows.

We _could_ consider running our notebooks on Windows too, but that will result
in a large explosion of tests being run, and thus will be investigated
separately (#1706).

This found 3 additional Windows-related issues:

- xfailed on windows: #1698, #1699
- fixed here: #1700

See: #1702, #1700
@huonw huonw closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sg-library
Projects
None yet
Development

No branches or pull requests

1 participant