Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests for temporal walks #828

Closed
8 tasks
kjun9 opened this issue Feb 10, 2020 · 0 comments
Closed
8 tasks

Add more unit tests for temporal walks #828

kjun9 opened this issue Feb 10, 2020 · 0 comments
Assignees
@kjun9
Labels
enhancement New feature or request experimental-blocker An issue that needs to be fixed before some `@experimental` feature can become non-experimental sg-library

Comments

@kjun9
Copy link
Contributor

kjun9 commented Feb 10, 2020

Description

We need to flesh out more of the unit tests for temporal walks to ensure the implementation is correct and necessarily checks are being performed on the input graph and parameters.

User Story

As a data scientist

I want to use temporal walks without running into problems

So that I can do my work

Done Checklist

  • Produced code for required functionality
  • Tests written and coverage checked
  • Code review performed
  • Documentation on Google Docs (if applicable)
  • Documentation in repo
  • Version number reflects new status
  • CHANGELOG.md updated
  • Team demo
@kjun9 kjun9 added enhancement New feature or request sg-library labels Feb 10, 2020
@kjun9 kjun9 self-assigned this Feb 10, 2020
@kjun9 kjun9 mentioned this issue Feb 10, 2020
Merged
kjun9 added a commit that referenced this issue Feb 11, 2020
@kjun9
Add temporal random walk as experimental (#787)
f8ca520 
Initial experimental implementation of temporal random walks.

Based on reference paper:

Giang Hoang Nguyen, John Boaz Lee, Ryan A. Rossi, Nesreen K. Ahmed, Eunyee
Koh, and Sungchul Kim. "Continuous-Time Dynamic Network Embeddings".
Proceedings of the 3rd International Workshop on Learning Representations
for Big Networks (WWW BigNet) 2018.

Part of #492 

Follow-ups #827 #828 #832
@huonw huonw added the experimental-blocker An issue that needs to be fixed before some `@experimental` feature can become non-experimental label Feb 19, 2020
This was referenced Mar 12, 2020
Closed
Merged
kjun9 added a commit that referenced this issue Mar 18, 2020
@kjun9
Add test for CTDNE cw_size and max_walk_length (#1083)
d0df56e 
Part of #828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjun9 kjun9

Labels
enhancement New feature or request experimental-blocker An issue that needs to be fixed before some `@experimental` feature can become non-experimental sg-library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@huonw @timpitman @kjun9