Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor interpretability code #829

Closed
8 tasks
kieranricardo opened this issue Feb 10, 2020 · 0 comments
Closed
8 tasks

Refactor interpretability code #829

kieranricardo opened this issue Feb 10, 2020 · 0 comments
Assignees
@kieranricardo
Labels
enhancement New feature or request sg-library

Comments

@kieranricardo
Copy link
Contributor

Description

Currently, there is a significant amount of duplicate code in the implementation of the GAT and GCN saliency maps. It would be useful to refactor this code before landing the GraphSage interpretability PR.

User Story

As a developer, I would like the code implementing saliency maps to clear, concise and modular to make it easier to implement new saliency maps.

Done Checklist

  • Produced code for required functionality
  • Tests written and coverage checked
  • Code review performed
  • Documentation on Google Docs (if applicable)
  • Documentation in repo
  • Version number reflects new status
  • CHANGELOG.md updated
  • Team demo
@kieranricardo kieranricardo added enhancement New feature or request sg-library labels Feb 10, 2020
@kieranricardo kieranricardo self-assigned this Feb 10, 2020
@kjun9 kjun9 closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kieranricardo kieranricardo

Labels
enhancement New feature or request sg-library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kieranricardo @kjun9