Mark Neo4j notebooks passed in demo notebook testing, not soft-fail #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit e514815 and detected 0 issues on this pull request. View more on Code Climate. |
kjun9
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now testing the Neo4j notebooks on CI (#1046), as a separate step to the main demo notebook testing one. The notebooks cannot be run in main step because they have dependencies (the GraphSAGE notebooks need to run the Cora ingestion notebook first, and all of them need to have py2neo installed), and so its correct to filter them out of that step, however filtering them out as "soft failures" is misleading: these notebooks aren't temporarily broken, they're permanently being tested elsewhere.
We can thus make our build summary convey exactly how many notebooks we're not testing (9 out of 36), by marking the parallel jobs that "run" (i.e. skip) the neo4j notebooks as passed, since they've successfully done what they're meant to do.