Remove "uniformly" from EdgeSplitter's negative sampling docs #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ab6bd76 and detected 0 issues on this pull request. View more on Code Climate. |
PantelisElinas
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sampling of negative edges isn't what many people would call uniform, because both local and global sampling shuffle the nodes and iterate over the shuffled nodes (reshuffling at the end) rather than selecting truly random nodes. This is effectively sampling without replacement, with "refreshing", rather than more conventional uniform sampling with replacement.
The fix we talked about in #838 was to just make the documentation less misleading by removing "uniform" from it.
See: #838