Symlink images into docs to be visible on Read the Docs #1468
Conversation
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
|
Code Climate has analyzed commit 901efc9 and detected 0 issues on this pull request. View more on Code Climate. |
| @@ -1146,6 +1146,15 @@ | |||
| "" | |||
| ] | |||
| }, | |||
There was a problem hiding this comment.
this still shows a broken link for me: https://github.com/stellargraph/stellargraph/blob/3e6a1356fdab02ea5e139ee457e8ce21ebacbd19/demos/ensembles/ensemble-link-prediction-example.ipynb
There was a problem hiding this comment.
Yeah, unfortunately I displaying "attachment" images doesn't work on Github. It does work on nbviewer and Read the Docs (and locally) though: https://nbviewer.jupyter.org/github/stellargraph/stellargraph/blob/3e6a1356fdab02ea5e139ee457e8ce21ebacbd19/demos/ensembles/ensemble-link-prediction-example.ipynb
This is a preexisting problem, e.g. from 0.10 many months ago: https://github.com/stellargraph/stellargraph/blob/v0.10.0/demos/ensembles/ensemble-link-prediction-example.ipynb
| "source": [ | ||
| "## Conclusion\n", | ||
| "\n", | ||
| "In this example, we used `stellargraph`s `BaggingEnsemble` class of GraphSAGE models to predict citation links in the Cora dataset. The `BaggingEnsemble` class brings ensemble learning to `stellargraph`'s graph neural network models, e.g., `GraphSAGE`, quantifying prediction variance and potentially improving prediction accuracy. " |
There was a problem hiding this comment.
The formatting here doesn't render well on rtd:
There was a problem hiding this comment.
Could you be more specific about what you mean?
That said, I think this can be removed now after #1460, there's no longer the block quote that hit spatialaudio/nbsphinx#450, and it works again on develop: https://stellargraph.readthedocs.io/en/latest/demos/ensembles/ensemble-link-prediction-example.html (see the end)
There was a problem hiding this comment.
For specifics, I meant "stellargraph" there doesn't work well with the (inconsistent) 's and s. This PR is now images only though
huonw
changed the title
The algorithm description images in the graph classification notebooks weren't visible in our documentation, which were flagged as Sphinx warnings:
See: #1360