Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance documemtation for keras node2vec #1566

Merged
merged 1 commit into from May 18, 2020
Merged

Conversation

daokunzhang
Copy link
Contributor

I make some minor changes on the node2vec wording introduction in the "demos/embeddings/keras-node2vec-embeddings.ipynb" and "demos/node-classification/keras-node2vec-node-classification.ipynb", as well as the word2vec illustration figure. I wish the description is more accurate and easier to be understood.

@daokunzhang daokunzhang requested a review from huonw May 15, 2020 02:27
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@codeclimate
Copy link

codeclimate bot commented May 15, 2020

Code Climate has analyzed commit 08396d0 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@daokunzhang daokunzhang merged commit e208665 into develop May 18, 2020
@daokunzhang daokunzhang deleted the bugfix/keras_node2vec branch May 18, 2020 01:14
@daokunzhang
Copy link
Contributor Author

daokunzhang commented May 18, 2020

Hi @huonw ,

After I merged this pull request to the develop branch, a buildkite failure occurred. How to fix this problem?

@huonw
Copy link
Member

huonw commented May 18, 2020

Both test failures are flaky tests that fail occasionally (#1115, #1569). At the moment we handle this by retrying the build. I've done so.

@daokunzhang
Copy link
Contributor Author

Thanks @huonw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants