New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a glossary #1570
Add a glossary #1570
Conversation
Code Climate has analyzed commit b75e517 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, this works very well on readthedocs - interesting to see just how easy this is with the features of rst (the only downside I could see is that Github doesn't render the rst properly).
🔤 👍
docs/glossary.rst
Outdated
|
||
iloc | ||
integer location | ||
Similar to Pandas, ilocs are sequential integers that allow for efficient storage and indexing. The :class:`stellargraph.StellarGraph` class typically stores external IDs as ilocs internally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to mention Pandas here, we could also link to them? Eg this link: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.iloc.html (though it's not as good as I'd hoped)
and from ilocs as required internally. Many of these methods also have a ``use_ilocs`` parameter | ||
that allows for explicitly switching the methods to consume and return ilocs directly, cutting out | ||
the conversion overhead. | ||
This type stores the external IDs for nodes and edges as :term:`ilocs <iloc>`. For convenience, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works very nicely!
This starts a glossary with a few terms. It's easy to append to it.
Rendered: https://stellargraph--1570.org.readthedocs.build/en/1570/glossary.html
See: #1268