Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a glossary #1570

Merged
merged 6 commits into from May 19, 2020
Merged

Add a glossary #1570

merged 6 commits into from May 19, 2020

Conversation

huonw
Copy link
Member

@huonw huonw commented May 18, 2020

This starts a glossary with a few terms. It's easy to append to it.

Rendered: https://stellargraph--1570.org.readthedocs.build/en/1570/glossary.html

See: #1268

@codeclimate
Copy link

codeclimate bot commented May 18, 2020

Code Climate has analyzed commit b75e517 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Security 1

View more on Code Climate.

@huonw huonw marked this pull request as ready for review May 18, 2020 05:05
Copy link
Contributor

@timpitman timpitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, this works very well on readthedocs - interesting to see just how easy this is with the features of rst (the only downside I could see is that Github doesn't render the rst properly).
🔤 👍


iloc
integer location
Similar to Pandas, ilocs are sequential integers that allow for efficient storage and indexing. The :class:`stellargraph.StellarGraph` class typically stores external IDs as ilocs internally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to mention Pandas here, we could also link to them? Eg this link: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.iloc.html (though it's not as good as I'd hoped)

and from ilocs as required internally. Many of these methods also have a ``use_ilocs`` parameter
that allows for explicitly switching the methods to consume and return ilocs directly, cutting out
the conversion overhead.
This type stores the external IDs for nodes and edges as :term:`ilocs <iloc>`. For convenience,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works very nicely!

@huonw huonw merged commit cc15f17 into develop May 19, 2020
@huonw huonw deleted the feature/1268-glossary branch May 19, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants