Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for edge weights in full-graph methods #1600

Merged
merged 7 commits into from May 29, 2020
Merged

Add support for edge weights in full-graph methods #1600

merged 7 commits into from May 29, 2020

Conversation

huonw
Copy link
Member

@huonw huonw commented May 27, 2020 •
edited

This adds a weighted parameter that passes through to to_adjacency_matrix calls, to recognise/use edge weights.

This includes:

  • GCN, GAT, APPNP, PPNP (via FullBatchNodeGenerator/FullBatchLinkGenerator and ClusterNodeGenerator)
  • RGCN (via RelationalFullBatchNodeGenerator)
  • graph classification including DGCNN (via PaddedGraphGenerator)

See: #1565

@codeclimate
Copy link

codeclimate bot commented May 27, 2020 •
edited

Code Climate has analyzed commit 956d1c1 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Security 2

View more on Code Climate.

@huonw huonw force-pushed the feature/1565-weighted-gcn branch from 03ed30d to fa567a7 Compare May 27, 2020 22:58
@huonw huonw changed the title Add support for edge weights in all methods that use adjacency matrices Add support for edge weights in full-graph methods May 28, 2020
@huonw huonw marked this pull request as ready for review May 28, 2020 02:35
@huonw huonw requested review from kieranricardo and kjun9 May 28, 2020 02:39
kjun9
kjun9 approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@kjun9 kjun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice 👍

stellargraph/connector/neo4j/graph.py Outdated Show resolved Hide resolved
huonw and others added 2 commits May 29, 2020 09:22
@huonw huonw merged commit d27fe68 into develop May 29, 2020
@huonw huonw deleted the feature/1565-weighted-gcn branch May 29, 2020 00:04
@huonw huonw mentioned this pull request Jun 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjun9 kjun9 kjun9 approved these changes

@kieranricardo kieranricardo Awaiting requested review from kieranricardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huonw @kjun9