Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove edge splitter progress update prints #1619

Merged
merged 2 commits into from Jun 1, 2020

Conversation

kjun9
Copy link
Contributor

@kjun9 kjun9 commented May 29, 2020

This removes progress update printing (every 1000 edges removed) for edge splitter.

Notebooks using edge splitter:

./ensembles/ensemble-link-prediction-example.ipynb
./link-prediction/node2vec-link-prediction.ipynb
./link-prediction/gcn-link-prediction.ipynb
./link-prediction/graphsage-link-prediction.ipynb
./embeddings/graphsage-unsupervised-sampler-embeddings.ipynb
./calibration/calibration-link-prediction.ipynb

Everything except the calibration one uses the Cora dataset which doesn't have enough edges to be printing any progress updates from the edge splitter, so just need to rerun the calibration notebook.

See #1454

@codeclimate
Copy link

codeclimate bot commented May 29, 2020

Code Climate has analyzed commit 8cb60d4 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 2

View more on Code Climate.

@kjun9 kjun9 requested a review from timpitman June 1, 2020 03:52
@kjun9 kjun9 marked this pull request as ready for review June 1, 2020 03:52
Copy link
Contributor

@timpitman timpitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@kjun9 kjun9 merged commit 3cde600 into develop Jun 1, 2020
@kjun9 kjun9 deleted the feature/1454-remove-edge-splitter-prints branch June 1, 2020 05:37
kjun9 pushed a commit that referenced this pull request Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants