Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup hrefs #1624

Merged
merged 1 commit into from May 29, 2020
Merged

cleanup hrefs #1624

merged 1 commit into from May 29, 2020

Conversation

TheDen
Copy link
Contributor

@TheDen TheDen commented May 29, 2020

PR:

  • Makes each <a> on a single line to make it easier to diff
  • Fixes the text-decoration underline visible in some editors (see attached image)

image

@TheDen TheDen requested a review from huonw May 29, 2020 06:29
@codeclimate
Copy link

codeclimate bot commented May 29, 2020

Code Climate has analyzed commit 7d07ec0 and detected 0 issues on this pull request.

View more on Code Climate.

huonw
huonw approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's part of the change that fixed the underlines?

@TheDen
Copy link
Contributor Author

TheDen commented May 29, 2020

The spacing between the closing</a>

@TheDen TheDen merged commit da5a0c4 into develop May 29, 2020
@TheDen TheDen deleted the feature/cleanup-hrefs branch May 29, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw huonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheDen @huonw