Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for saving and loading every model #1676

Merged
merged 5 commits into from Jun 16, 2020
Merged

Conversation

huonw
Copy link
Member

@huonw huonw commented Jun 12, 2020

This PR test saving and loading of a tf.keras.Model instance for every model in StellarGraph.

It does so by adding a test_utils.model_save_load helper function that serialises and deserialisers a given model using various APIs provided by TensorFlow:

Several of these new tests fail (they're included but marked as xfail), due to:

As those issues are fixed, the xfailing can be removed.

@codeclimate
Copy link

codeclimate bot commented Jun 12, 2020

Code Climate has analyzed commit c1a5293 and detected 0 issues on this pull request.

View more on Code Climate.

@huonw huonw removed the request for review from kjun9 June 15, 2020 00:19
@huonw huonw requested a review from timpitman June 15, 2020 01:43
Copy link
Contributor

@timpitman timpitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, glad that this is being tested even if there's xfails to address now.

@huonw huonw merged commit 498356e into develop Jun 16, 2020
@huonw huonw deleted the feature/saving-tests branch June 16, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants