Run Neo4j notebooks on GitHub Actions #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feature/1687-github-actions-notebooks
to
develop
June 22, 2020 00:39
huonw
added a commit
that referenced
this pull request
Jun 22, 2020
This runs all the basic Jupyter notebooks on Github Actions, in parallel. It does this in the simplest way to get parallelism (and also, the simplest way to get a "loop" in GitHub Actions configuration), with a large job matrix: https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategymatrix The matrix has to be manually specified, so a new script `scripts/ci/ci_workflow_notebook_list.py` is added, that checks that the matrix of notebooks matches the notebooks on disk. This script is better if it is simple, and it's better if the configuration all in one place in the `ci.yml` file. Thus, the notebooks that aren't run in the default configuration (such as Neo4j notebooks #1694, and notebooks that fail #818 #819) are still listed and then excluded with `exclude`: https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-excluding-configurations-from-a-matrix See: #1687
…b-actions-neo4j-notebooks
|
Code Climate has analyzed commit af19d77 and detected 0 issues on this pull request. View more on Code Climate. |
timpitman
approved these changes
Jun 22, 2020
scripts/ci/docker-compose.yml
Outdated
| @@ -0,0 +1,13 @@ | |||
| --- | |||
There was a problem hiding this comment.
could this file should have a more descriptive name than just "docker-compose.yml"?
There was a problem hiding this comment.
Potentially, but maybe the ci directory name is enough?
There was a problem hiding this comment.
I'll rename to "actions-docker-compose.yml" since it's having to be used with the -f argument anyway and so docker-compose's default of looking for ./docker-compose.yml doesn't help.
…b-actions-neo4j-notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on #1692 to also run the notebooks that use Neo4j on our new GitHub Actions CI.
It does this by using docker-compose to manually run the Neo4j image in the background. This is a bit clunky, but is done in the interests of getting something working now. In particular, I couldn't work out how to use the native support for "services" for a job (https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idservices) to build the image from a local dockerfile.
See: #1687