Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/graphwalk neighbors #408

Merged
merged 4 commits into from Jun 4, 2019
Merged

Fix/graphwalk neighbors #408

merged 4 commits into from Jun 4, 2019

Conversation

youph
Copy link
Contributor

@youph youph commented May 28, 2019

Simplification of GraphWalk base class's method neighbors: we don't need to pass graph to it, as it can use self.graph.

@youph youph requested a review from adocherty May 28, 2019 07:45
@youph youph added the ml label May 28, 2019
@codeclimate
Copy link

codeclimate bot commented May 28, 2019

Analysis results are not available for those commits

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 84.226% when pulling 59fee24 on fix/graphwalk_neighbors into 674038f on develop.

adocherty
adocherty approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@adocherty adocherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@adocherty adocherty merged commit 96e0cc5 into develop Jun 4, 2019
@adocherty adocherty deleted the fix/graphwalk_neighbors branch June 5, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adocherty adocherty adocherty approved these changes

Assignees

@adocherty adocherty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@youph @coveralls @adocherty