Use the new StellarGraph for Cora examples #795
Conversation
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
stellargraph/core/element_data.py
Outdated
| start = self._type_element_ilocs[type_name].start | ||
| feature_ilocs = id_ilocs - start | ||
|
|
||
| # FIXME: better error messages |
There was a problem hiding this comment.
Take the required action to fix the issue indicated by this "FIXME" comment.
stellargraph/core/graph.py
Outdated
| if self._graph is not None: | ||
| return self._graph.edges(triple) | ||
|
|
||
| # FIXME: these would be better returned as the 2 or 3 arrays directly, rather than tuple-ing |
There was a problem hiding this comment.
Take the required action to fix the issue indicated by this "FIXME" comment.
stellargraph/core/graph.py
Outdated
| # models that build fixed-size structures (e.g. GraphSAGE) based on neighbours to fill out | ||
| # missing neighbours with zeros automatically, using None as a sentinel. | ||
|
|
||
| # FIXME: None as a sentinel forces nodes to have dtype=object even with integer IDs, could |
There was a problem hiding this comment.
Take the required action to fix the issue indicated by this "FIXME" comment.
stellargraph/core/element_data.py
Outdated
| self._nodes.ids.to_iloc(self.sources), minlength=len(self._nodes) | ||
| ) | ||
|
|
||
| assert len(degrees) == len(self._nodes) |
There was a problem hiding this comment.
Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
|
Code Climate has analyzed commit 0cece3d and detected 0 issues on this pull request. View more on Code Climate. |
huonw
force-pushed
the
feature/717-cora-demo
branch
from
5bd5a27
to
baff22b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #795 +/- ##
===========================================
- Coverage 82.74% 82.18% -0.57%
===========================================
Files 46 46
Lines 5391 5159 -232
===========================================
- Hits 4461 4240 -221
+ Misses 930 919 -11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #795 +/- ##
=========================================
+ Coverage 82.2% 82.6% +0.4%
=========================================
Files 46 47 +1
Lines 5159 5328 +169
=========================================
+ Hits 4240 4400 +160
- Misses 919 928 +9
Continue to review full report at Codecov.
|
This doesn't convert the link prediction examples that use Cora because they don't load the data in the same way.
See: #717
(Reopening of #720 due to #786.)