Parametrise GAT interpretability demo to run faster on CI #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
huonw
added a commit
that referenced
this pull request
Feb 18, 2020
This does a small change to `node-link-importance-demo-gat.ipynb` to get it working again after the switch to the new `StellarGraph` class. In particular, the change to the new StellarGraph changed the order in which nodes appear. so: 1. the code that was (effectively) `G.nodes()[7]` was no longer selecting the node with ID `1109199` 2. the code that was translating between IDs and indices was sometimes doing it via the `Gnx` (the NetworkX graph) and sometimes via `G`/`graph_nodes` (the `StellarGraph`) which gave different results. This switches 1 to starting with the actual node ID of interest, and 2 to always using a single list (`graph_nodes` or `nodes` as appropriate). The code is quite poor in many ways here (all of the `.index` calls are O(n)), but in the interests of getting this fixed as soon as possible, this tries to keep the changes here minimal and not make any improvements. The work to get this notebook running on CI is a little intricate/fiddly (#881). See: #868
huonw
force-pushed
the
bugfix/819-interpretability-gat-ci
branch
from
5b468ae
to
e11a810
Compare
Codecov Report
@@ Coverage Diff @@
## bugfix/868-node-importance-gat #881 +/- ##
================================================================
- Coverage 87.2% 82.3% -4.9%
================================================================
Files 47 45 -2
Lines 5697 4901 -796
================================================================
- Hits 4967 4032 -935
- Misses 730 869 +139
Continue to review full report at Codecov.
|
huonw
changed the base branch from
bugfix/868-node-importance-gat
to
develop
huonw
force-pushed
the
bugfix/819-interpretability-gat-ci
branch
from
e11a810
to
002a82a
Compare
|
Code Climate has analyzed commit b045b76 and detected 0 issues on this pull request. View more on Code Climate. |
huonw
force-pushed
the
bugfix/819-interpretability-gat-ci
branch
from
002a82a
to
2ca2865
Compare
huonw
force-pushed
the
bugfix/819-interpretability-gat-ci
branch
from
2ca2865
to
00be110
Compare
huonw
force-pushed
the
bugfix/819-interpretability-gat-ci
branch
from
5c73e4c
to
e49c54a
Compare
huonw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1744, we enabled the basic interpretability notebooks on CI, but it takes 12 minutes to run (15 minutes total): https://github.com/stellargraph/stellargraph/runs/820744662
This PR parameterises the demo to run faster and use less CI time.
See: #819