Remove NodeSplitter and train_val_test_split #887
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NodeSplitter
class and thetrain_val_test_split
function seemingly have only been used in their own tests for quite a while now, specifically:NodeSplitter
(by deletingdemos/StellarGraph_examples.ipynb
),train_val_test_split
(by deletingdemos/node-classification-hinsage/generalization-tests.py
).Given these aren't used in our examples, it seems like we can probably remove them, and reduce how much code we need to maintain.
Replacement: manually cutting up a
pandas
data frame, or usingsklearn.model_selection.train_test_split
(most of our examples do the latter, now).See: #885