New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove demo scripts that duplicate notebooks (#575) #889
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
Code Climate has analyzed commit d843e8c and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## develop #889 +/- ##
=========================================
- Coverage 85.7% 85.1% -0.6%
=========================================
Files 45 49 +4
Lines 4901 5014 +113
=========================================
+ Hits 4200 4266 +66
- Misses 701 748 +47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
As for the HinSAGE script, I think we should turn that into a notebook as well even if we can't run it in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that's what you want to do, then deleting the scripts is fine by me.
|
Over time, StellarGraph has moved to Jupyter notebooks for demos, rather than scripts.
After some discussion, it appears that the demo scripts were generally used for development and debugging, and hence are no longer required. Removing them will remove the need to add them to CI for #575 and will also reduce our code surface for future refactoring, allowing us to concentrate on demo notebooks.
The only script remaining is:
demos/node-classification/hinsage
- this has no Jupyter notebook equivalent, and also can't be tested on CI due to use of theYELP
dataset, and is listed with other untestable notebooks in #818.