Make HinSAGE reproducible #926
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -75,7 +75,7 @@ def __init__(self, G, batch_size, schema=None): | |||
| def sample_features(self, head_links, batch_num): | |||
| pass | |||
|
|
|||
| def flow(self, link_ids, targets=None, shuffle=False): | |||
| def flow(self, link_ids, targets=None, shuffle=False, seed=None): | |||
There was a problem hiding this comment.
Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.
|
Code Climate has analyzed commit 69270e9 and detected 0 issues on this pull request. View more on Code Climate. |
|
Hmm.. something is still flaky, investigating the test failure now |
Codecov Report
@@ Coverage Diff @@
## develop #926 +/- ##
=========================================
- Coverage 85.4% 84.5% -0.9%
=========================================
Files 66 58 -8
Lines 6774 4956 -1818
=========================================
- Hits 5784 4186 -1598
+ Misses 990 770 -220
Continue to review full report at Codecov.
|
tests/mapper/test_node_mappers.py
Outdated
| ] | ||
| features, labels = zip(*batches) | ||
| features, labels = np.concatenate(features), np.concatenate(labels) | ||
| assert all(features == labels) |
There was a problem hiding this comment.
I think this can be:
| assert all(features == labels) | |
| assert np.array_equal(features, labels) |
tests/mapper/test_node_mappers.py
Outdated
|
|
||
| for i in range(max_iter): | ||
| f1, f2 = consecutive_epochs(seq) | ||
| comparison_results.add(all(f1 == f2)) |
There was a problem hiding this comment.
Same here:
| comparison_results.add(all(f1 == f2)) | |
| comparison_results.add(np.array_equal(f1, f2)) |
tests/mapper/test_node_mappers.py
Outdated
|
|
||
| for i in range(max_iter): | ||
| f1, f2 = consecutive_epochs(seq) | ||
| comparison_results.add(all(f1 == f2)) |
There was a problem hiding this comment.
could the assertions happen in this line?
| comparison_results.add(all(f1 == f2)) | |
| if shuffle: | |
| assert not np.array_equal(f1, f2) | |
| else: | |
| assert np.array_equal(f1, f2) |
kjun9
force-pushed
the
feature/749-hinsage
branch
from
a54510b
to
69270e9
Compare
|
It should be blamed on random state use multiple times, which will generate different results. The following steps guarantee consistent results even at every epoch.
|
This is for both NAI and link prediction, which are the two tasks currently available for HinSAGE
Part of #749