Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations included in 0.10 release #969

Merged
merged 6 commits into from Feb 28, 2020

Conversation

huonw
Copy link
Member

@huonw huonw commented Feb 26, 2020

This includes simplifying BlogCatalog3.load because we no longer need to support load_dataset_BlogCatalog3.

See: #959

@codeclimate
Copy link

codeclimate bot commented Feb 26, 2020

Code Climate has analyzed commit 96d6bcb and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Security 1

View more on Code Climate.

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #969 into develop will decrease coverage by <.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #969     +/-   ##
=========================================
- Coverage     84.4%   84.4%   -<.1%     
=========================================
  Files           58      53      -5     
  Lines         4945    5168    +223     
=========================================
+ Hits          4176    4364    +188     
- Misses         769     804     +35
Impacted Files Coverage Δ
stellargraph/core/graph.py 98.5% <ø> (-0.1%) ⬇️
stellargraph/data/loader.py 42.1% <ø> (+4.6%) ⬆️
stellargraph/datasets/datasets.py 68.9% <0%> (+1.7%) ⬆️
stellargraph/ensemble.py 85.5% <0%> (ø)
stellargraph/calibration.py 79.9% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21bd6b8...96d6bcb. Read the comment docs.

@huonw huonw marked this pull request as ready for review February 27, 2020 00:30
Comment on lines 203 to 205
Deprecated, use :meth:`from_networkx`.
edge_type_name:
Deprecated, use :meth:`from_networkx`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple of deprecated arguments still here. (+ graph and node_type_name above that github wont let me suggest changes for)

Suggested change
Deprecated, use :meth:`from_networkx`.
edge_type_name:
Deprecated, use :meth:`from_networkx`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had carefully left these ones here despite removing the adjacent edge_weight_label because these arguments are not properly deprecated: they don't trigger a runtime warning yet. I think it's important that we use a runtime warning to prompt people to move because:

  • user with existing code won't re-read the docs, and
  • they may not realise that a breaking change listed in the CHANGELOG affects their code (as in, they may not remember all the details about their code)

These arguments don't trigger a runtime warning yet because "FIXME(#717): this should have a deprecation warning, once the tests and examples have stopped using it" on line 253/241 below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool that makes sense; everything looks good then

Comment on lines 206 to 207
node_features:
Deprecated, use :meth:`from_networkx`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node_features:
Deprecated, use :meth:`from_networkx`.

Copy link
Contributor

@kieranricardo kieranricardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@huonw huonw merged commit 83348aa into develop Feb 28, 2020
@huonw huonw deleted the feature/959-no-deprecations branch February 28, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants