This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
add url datatype #29
Merged
add url datatype #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigercosmos
suggested changes
Apr 5, 2019
src/component/table.rs
Outdated
| fn is_value_valid(value: &str, datatype: &DataType) -> bool { | ||
| match datatype { | ||
| DataType::Url => { | ||
| let re = Regex::new(r"^(http|https)?://[\w\-\.]+(:\d+)?(/[~\w/\.]*)?(\?\S*)?(#\S*)?").unwrap(); |
There was a problem hiding this comment.
127.0.0.1 似乎不會過？
url 前面的 scheme 不止 https 和 http，其實可以是任何東西，而且也不一定要加，我是覺得就不用檢查
src/sql/lexer.rs
Outdated
|
|
||
| loop { | ||
| match chars.next() { | ||
| Some(x) => { | ||
| if is_identifier_char(x) || is_operator(x) { | ||
| if (x == '"') || is_quoted { |
There was a problem hiding this comment.
他有可能是 ' 和 "
lexer.rs 下面的 test 補一下
不然看不出有沒有 bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.