#409 Update relationship between NACL and its entries #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Apr 8, 2020
ghost
reviewed
Apr 8, 2020
ghost
suggested changes
Apr 8, 2020
There was a problem hiding this comment.
don't need to populate stuff that the model already does.... seems like the add for this PR is that the NACL has a set of NACLEntry objects. don't need to explicitly objectify the Entry objects if there isn't a synthetic attribute (but the list of Entry objects is synthetic)
ghost
approved these changes
Apr 8, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to stelligent/cfn_nag#409 and #74
Updates the relationship to be parsed between EC2 Network ACLs and Network ACL Entries to no longer be separated by egress and ingress and to include all entry items, not just their logical resource IDs.
Planned to be used in conjunction with: stelligent/cfn_nag#423